Update _svds.py removing no longer necessary QR for LOBPCG output #17651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QR of lobpcg eigenvectors should be no longer needed after gh-16320 is merged and can be removed still passing all tests
editing of apparently typos in formatting quotes
|
The failure looks unrelated, so ready for review and merge. |
windows-server-2003
pushed a commit
to windows-server-2003/scipy
that referenced
this pull request
Jan 9, 2023
…put (scipy#17651) * Update _svds.py QR of lobpcg eigenvectors should be no longer needed after scipygh-16320 is merged and can be removed still passing all tests * formatting quotes in docstring editing of apparently typos in formatting quotes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QR of lobpcg eigenvectors should be no longer needed since gh-16320 is merged and can be removed still passing all tests
Some issues with formatting using the quotes in the docstring needs fixing
Reference issue
N/A
What does this implement/fix?
QR of lobpcg eigenvectors is no longer needed after gh-16320 is merged and thus removed still passing all tests.
All issues with formatting using the quotes in the docstring are fixed.
Additional info?
There is a file _svds_doc.py in the same directory, I am unsure what for and how related to the docstring in _svds.py that I am lightly editing in this PR.