MAINT: Cast datasets.ascent image to float64
#17627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: boeleman <[email protected]>
tylerjereddy
approved these changes
Dec 19, 2022
There was a problem hiding this comment.
I checked that the CI failures don't appear to be related, see gh-17630.
It looks like there's something nasty with the NumPy dev branch as well, but almost certainly not related. I'll check that locally now and update the above issue when I confirm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
xref #17606 #17611 scipy/dataset-ascent#3
What does this implement/fix?
ascent dataset array has been updated to uint8 dtype at source file, this should fix the breaking signal docs due to the same.
Thanks @boeleman for the initial PR.
cc @tylerjereddy @rgommers