BLD: fix invalid shebang for build helper script #17210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shebangs do not work this way, but Meson could usually paper over the differences by noticing that the last element is "python3" and rewiring it to use its own sys.executable. However, this failed on WSL, likely because platform quirks meant the script was directly executable, while simultaneously having a shebang that was a fatal error. Use a standard shebang indicating this script would like to run with some form of python3 (which is exactly what it needs). Fixes scipy#17020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shebangs do not work this way, but Meson could usually paper over the differences by noticing that the last element is "python3" and rewiring it to use its own sys.executable. However, this failed on WSL, likely because platform quirks meant the script was directly executable, while simultaneously having a shebang that was a fatal error.
Use a standard shebang indicating this script would like to run with some form of python3 (which is exactly what it needs).
Fixes #17020