Fix explanation of LIst of List sparse matrix #17027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to CJ Carey for catching the mistake. Sparse was introduced to SciPy in this commit: scipy/scipy-svn@b3827de A later update included a list of formats: scipy/scipy-svn@39730dc In both these patches the phrase "linked list matrix" is used, but I believe erroneously. The LIst of List format uses the following representation: ``` In [1]: import scipy.sparse In [2]: X = scipy.sparse.lil_matrix([[0,0,0,0],[0,1,0,0],[0,0, ...: 0,0]]) In [3]: X.data Out[3]: array([list([]), list([1]), list([])], dtype=object) ``` The intent is to have direct access to any row. This can be achieved with a list of lists, but not with a linked list representation.
perimosocordiae
approved these changes
Sep 16, 2022
|
Thanks! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to CJ Carey for catching the mistake.
Sparse was introduced to SciPy in this commit:
scipy/scipy-svn@b3827de
A later update included a list of formats:
scipy/scipy-svn@39730dc
In both these patches the phrase "linked list matrix" is used, but I believe erroneously. The LIst of List format uses the following representation:
The intent is to have direct access to any row. This can be achieved with a list of lists, but not with a linked list representation.