MAINT: special: remove one libnpymath dependency; more NPY_ -> C99
#16816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…9 changes Replacements: - `NPY_NAN` -> `NAN` - `NPY_INFINITY` -> `INFINITY` - `NPY_PI` -> `M_PI` - `NPY_E` -> `M_E` - `npy_isnan` -> `isnan` - `npy_isinf` -> `isinf` - `npy_isfinite` -> `isfinite` - `npy_copysign` -> `copysign` - `npy_signbit` -> `signbit` Also cleans up a lot of Cython imports, and removes one `libnpymath` inclusion. That removal reduces binary size and works towards not depending on `libnpymath` at all - see numpy/numpy#20880
h-vetinari
reviewed
Aug 10, 2022
|
The one failure ( |
h-vetinari
reviewed
Aug 10, 2022
[ci skip] Co-authored-by: h-vetinari <[email protected]>
dd2a540 to
44a425e
Compare
|
LGTM. Squash-merged as requested to keep the ball rolling, thanks Ralf, all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacements:
NPY_NAN->NANNPY_INFINITY->INFINITYNPY_PI->M_PINPY_E->M_Enpy_isnan->isnannpy_isinf->isinfnpy_isfinite->isfinitenpy_copysign->copysignnpy_signbit->signbitAlso cleans up a lot of Cython imports, and removes one
libnpymathinclusion. That removal reduces binary size and works towards not depending onlibnpymathat all - see numpy/numpy#20880.Things brings us down to 13 places where we still include
numpy/npy_math.h.