Skip to content

DEP: deprecate spatial.distance.kulsinski #16265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 24, 2022
Merged

DEP: deprecate spatial.distance.kulsinski #16265

merged 5 commits into from
May 24, 2022

Conversation

j-bowhay
Copy link
Member

Reference issue

Closes #15125
Supersedes #15180

What does this implement/fix?

Finished off the pr started by @deepakdinesh1123 to deprecate spatial.distance.kulsinski.

Additional information

@tupui is this the correct way to give attribution to the work originally done by @deepakdinesh1123 ?

@tupui tupui added scipy.spatial deprecated Items related to behavior that has been deprecated labels May 24, 2022
Copy link
Member

@tupui tupui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @j-bowhay for the quick work. I will wait for the CI but at first glance it looks good. (seeing a failure but unrelated and might be due to the fact that you merged an old remote instead of upstream main. So Azure does not have latest.)

@tupui is this the correct way to give attribution to the work originally done by @deepakdinesh1123

Yes it's perfect since you preserved the original commits, thank you.

@tupui tupui added this to the 1.9.0 milestone May 24, 2022
@tupui tupui merged commit 89a78ae into scipy:main May 24, 2022
@tupui
Copy link
Member

tupui commented May 25, 2022

I missed this from the CI. We had other intermittent bug there and wrongly assumed it was the same.

======================
scipy.spatial.distance
======================

Non-deprecated objects in __all__: 29
Objects in refguide: 30

ERROR: missing objects::

    kulsinski

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecated Items related to behavior that has been deprecated scipy.spatial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate scipy.spatial.distance.kulsinski
3 participants