Skip to content

DEP: remove signal.windows.hanning #15881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2022
Merged

DEP: remove signal.windows.hanning #15881

merged 1 commit into from
Mar 27, 2022

Conversation

jyuv
Copy link
Contributor

@jyuv jyuv commented Mar 26, 2022

Reference issue

Closes #15745

What does this implement/fix?

Remove the deprecated windows.hanning method. removed it also from test_windows and from all in signal & windows modules

Additional information

@jyuv jyuv requested review from larsoner and ilayn as code owners March 26, 2022 13:02
@h-vetinari h-vetinari added scipy.signal deprecated Items related to behavior that has been deprecated labels Mar 27, 2022
@h-vetinari h-vetinari added this to the 1.9.0 milestone Mar 27, 2022
tylerjereddy
tylerjereddy approved these changes Mar 27, 2022
View reviewed changes
Copy link
Contributor

@tylerjereddy tylerjereddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecated since 1.1.0, which should be long enough, and the CI timeout is not related.

Diff looks sensible to me.

@tylerjereddy tylerjereddy merged commit 1c1a467 into scipy:main Mar 27, 2022
@tylerjereddy
Copy link
Contributor

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerjereddy tylerjereddy tylerjereddy approved these changes

@larsoner larsoner Awaiting requested review from larsoner larsoner is a code owner

@ilayn ilayn Awaiting requested review from ilayn ilayn is a code owner

Assignees
No one assigned
Labels
deprecated Items related to behavior that has been deprecated scipy.signal
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

DEP: remove signal.windows.hanning
3 participants
@jyuv @tylerjereddy @h-vetinari