Skip to content

DEP: remove sym_pos argument from linalg.solve #15873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 15, 2022
Merged

DEP: remove sym_pos argument from linalg.solve #15873

merged 2 commits into from
Dec 15, 2022

Conversation

jyuv
Copy link
Contributor

@jyuv jyuv commented Mar 26, 2022

Reference issue

Closes #15829

What does this implement/fix?

Remove sym_pos argument from linalg.solve. Deleted also the test_sym_pos_dep test which checked if using a sym_pos argument will raise a DeprecationWarning

Additional information

@jyuv jyuv requested review from larsoner and ilayn as code owners March 26, 2022 12:31
@ilayn
Copy link
Member

ilayn commented Mar 26, 2022

Thanks @jyuv . This deprecation has been recently added to main and will start emitting warnings until version 1.11.

@h-vetinari h-vetinari added scipy.linalg deprecated Items related to behavior that has been deprecated labels Mar 27, 2022
@h-vetinari h-vetinari added this to the 1.11.0 milestone Mar 27, 2022
@rgommers
Copy link
Member

Thanks @jyuv for the PRs. I will close the ones that aren't mergeable for until next year; if we leave them open until 1.11.0 development starts then maintainers see this in their review queue and spend too much time on it. It can be reopened in the future.

@rgommers rgommers closed this Mar 27, 2022
@rgommers rgommers mentioned this pull request Mar 28, 2022
Closed
@j-bowhay
Copy link
Member

j-bowhay commented Dec 7, 2022

Ditto, reopening now development has started for 1.11.0

@j-bowhay j-bowhay reopened this Dec 7, 2022
tupui
tupui approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@tupui tupui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and failures in CI are unrelated (Cirrus seems to fail when PRs are old for some reason. Although here I merged main when resolving a conflict.). Thanks again @jyuv

@tupui tupui merged commit c1d212b into scipy:main Dec 15, 2022
@h-vetinari
Copy link
Member

I added a release note for this (and your other PRs, @jyuv), please double-check :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tupui tupui tupui approved these changes

@larsoner larsoner Awaiting requested review from larsoner larsoner is a code owner

@ilayn ilayn Awaiting requested review from ilayn ilayn is a code owner

Assignees
No one assigned
Labels
deprecated Items related to behavior that has been deprecated scipy.linalg
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.

DEP: remove sym_pos-keyword of scipy.linalg.solve
6 participants
@jyuv @ilayn @rgommers @j-bowhay @h-vetinari @tupui