Skip to content

MAINT: make unuran clone shallow #15555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 9, 2022
Merged

MAINT: make unuran clone shallow #15555

merged 1 commit into from
Feb 9, 2022

Conversation

ev-br
Copy link
Member

@ev-br ev-br commented Feb 8, 2022

Use a shallow clone for unuran submodule, to minimize the download traffic a bit.

tupui
tupui approved these changes Feb 8, 2022
View reviewed changes
Copy link
Member

@tupui tupui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible, thanks @ev-br. Should we also do it for the doc extensions?

@tupui tupui self-assigned this Feb 8, 2022
@tupui tupui added DX Everything related to making the experience of working on SciPy more pleasant maintenance Items related to regular maintenance tasks labels Feb 8, 2022
@tupui tupui added this to the 1.9.0 milestone Feb 8, 2022
@tylerjereddy
Copy link
Contributor

Alright, there is a core developer approval for what looks like a straightforward config improvement so I'll put it in, thanks.

@tylerjereddy tylerjereddy merged commit 13b02c7 into scipy:main Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tupui tupui tupui approved these changes

Assignees

@tupui tupui

Labels
DX Everything related to making the experience of working on SciPy more pleasant maintenance Items related to regular maintenance tasks
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ev-br @tylerjereddy @tupui