Skip to content

TST: split combined LSAP input validation tests up #14291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2021

Conversation

pmla
Copy link
Contributor

@pmla pmla commented Jun 24, 2021

What does this implement/fix?

The input validation checks for the optimize.linear_sum_assignment module are all combined in a single test. This makes development harder because the test output is not very fine grained.

Here I have split the tests up.

@pmla pmla added maintenance Items related to regular maintenance tasks scipy.optimize labels Jun 24, 2021
Copy link
Contributor

@tylerjereddy tylerjereddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, this is better for testing, and clearly testing the same stuff, even to a non-expert.

@tylerjereddy tylerjereddy added this to the 1.8.0 milestone Jun 25, 2021
@tylerjereddy tylerjereddy merged commit 7ed8612 into scipy:master Jun 25, 2021
@tylerjereddy
Copy link
Contributor

thanks @pmla

@pmla
Copy link
Contributor Author

pmla commented Jun 25, 2021

Thanks @tylerjereddy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Items related to regular maintenance tasks scipy.optimize
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants