Skip to content

REL: add PEP 621 (project metadata in pyproject.toml) support #13929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2021

Conversation

rgommers
Copy link
Member

Static metadata in a format that all packaging tools understand will be beneficial in the long term. PEP 621 (https://www.python.org/dev/peps/pep-0621/) became final last month, so let's support it.

pip doesn't have support yet it looks like, so can't really test. But this is all straightforward, should be correct (and can't break anything if CI passes). I based this on both the PEP itself and on flit's implementation.

@takluyver would you mind having a quick look at this?

@rgommers rgommers added the maintenance Items related to regular maintenance tasks label Apr 24, 2021
@rgommers rgommers requested a review from larsoner as a code owner April 24, 2021 13:15
@takluyver
Copy link
Contributor

Looks OK at a quick glance. I think the idea is that build backends (like setuptools) will add support, and then you can specify metadata like this instead of in setup.py or setup.cfg. Until then, there may be little concrete benefit to adding this (and there's always some risk that some detail won't quite fit with what setuptools expects when it does add support).

@rgommers
Copy link
Member Author

Thanks Thomas.

Until then, there may be little concrete benefit to adding this (and there's always some risk that some detail won't quite fit with what setuptools expects when it does add support).

Makes sense in principle. However, I'm planning to move away from distutils / setuptools, and this is a small step in that direction. And we're anyway putting an upper bound on setuptools so if this PR ends up in SciPy 1.7.0 and then setuptools decided to do something odd, nothing will break. pip is another story of course, but that won't affect releases.

@rgommers rgommers added enhancement A new feature or improvement and removed maintenance Items related to regular maintenance tasks labels Apr 26, 2021
Copy link
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to merge if you're done @rgommers

@rgommers rgommers merged commit 9ab417e into scipy:master Apr 27, 2021
@rgommers
Copy link
Member Author

Thanks Eric and other reviewers, done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A new feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants