MAINT: move LSAP maximization handling into solver code #13883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@peterbell10 any comments on this? If not I will go ahead and merge as the changes are quite small. |
peterbell10
approved these changes
Jun 23, 2021
|
Thanks @pmla, I must have missed the notification first time around. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
In line with #13860 and #13870, I have moved maximization handling into the solver code of
scipy.optimize.linear_sum_assignmentAdditional information
@peterbell10: almost finished with this round of maintenance. The last bit is to move the remaining parts of
_lsap.pyinto the binding code.