TST: fix failures due to new FutureWarnings in NumPy 1.21.dev0 #13473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The warnings were: FutureWarning: Promotion of numbers and bools to strings is deprecated. The `test_lfilter_bad_object` changes from ValueError to TypeError. The changes in behaviour should be due to the refactoring in the NumPy dtype system. There's not much point keeping these tests, more trouble than they're worth. Closes scipygh-13472
|
This seems to have worked, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The warnings were:
The
test_lfilter_bad_objectchanges from ValueError to TypeError.The changes in behaviour should be due to the refactoring in
the NumPy dtype system. There's not much point keeping these
tests, more trouble than they're worth.
Closes gh-13472