BUG: Fix memory leak in shgo triangulation #10990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simply removing the cache and keeping the cached functions was slightly slower during tests. Inlining generate_sub_cell_t1 and generate_sub_cell_t2 at their single point of use gave back the lost performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10987
This removes the unnecessary lru_cache responsible for the
memory leak.
Simply removing the cache and keeping the cached functions
was slightly slower during tests.
Inlining generate_sub_cell_t1 and generate_sub_cell_t2
at their single point of use gave back the lost performance.