Skip to content

Conversation

glemaitre
Copy link
Member

closes #29062

Add the prefit parameter to the FixedThresholdClassifier allowing to accept a prefitted estimator without refitting it when calling fit.

Copy link

github-actions bot commented May 21, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: a99517f. Link to the linter CI: here

@glemaitre glemaitre added this to the 1.6 milestone May 21, 2024
@glemaitre
Copy link
Member Author

@koaning do you want to have a look at the diff?

Copy link

@koaning koaning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a fast turn-around! But yeah this looks ace.

Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a few comments

@glemaitre
Copy link
Member Author

The error is unrelated

Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion otherwise LGTM. Thanks @glemaitre

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Don't refit in FixedThresholdClassifier when original model is already trained.
4 participants