API Deprecates support for np.matrix in check_array #20165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just that this comes from upper numpy authority :) But as you wish. |
thomasjpfan
commented
Jun 1, 2021
There was a problem hiding this comment.
@ogrisel I added the link to np.matrix in the warning message.
| "np.matrix usage is deprecated in 1.0 and will raise a TypeError " | ||
| "in 1.2. Please convert to a numpy array with np.asarray. For " | ||
| "more information see: " | ||
| "https://numpy.org/doc/stable/reference/generated/numpy.matrix.html", # noqa |
There was a problem hiding this comment.
Splitting the URL into two lines would make it harder to navigate to the URL when browsing the code.
lorentzenchr
approved these changes
Jun 1, 2021
thomasjpfan
added a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Jun 1, 2021
…earn#20165)" This reverts commit 6850c04.
This was referenced Jul 12, 2021
54 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Related to #10993 (comment)
What does this implement/fix? Explain your changes.
Deprecates
np.matrixincheck_arrayin 1.0.Any other comments?
@ogrisel What is the reasoning behind linking to https://numpy.org/doc/stable/reference/generated/numpy.matrix.html ? Was it to show users the "It is no longer recommended to use this class ... " message?