Fix setup.py

[chkoar]

• I think that the distname should be scikit-learn-extra not sklearn-extra
• Should we add support for Python 3.8 since the latest version of scikit-learn has support for it?

[rth]

I think that the distname should be scikit-learn-extra not sklearn-extra

Indeed.

Should we add support for Python 3.8 since the latest version of scikit-learn has support for it?

+1 .

I also think we can can also drop 3.5 and support only 1 latest version of scikit-learn this for now being more experimental so far. If I remember correctly @glemaitre mentioned that at some point.

[chkoar]

My recent experience along with @glemaitre says that we should decide how many versions we should support (the latest released minor for instance). Apart from that I believe that we should test against the upstream in the periodic manner otherwise you may get an irrelevant failures in PRs.

[chkoar]

And as I wrote here in the readme we state that scikit-learn-extra requires scikit-learn (>=0.21) where the 3.5 was supported.

[rth]

And as I wrote here in the readme we state that scikit-learn-extra requires scikit-learn (>=0.21) where the 3.5 was supported.

I wouldn't worry about that. Say scikit-learn supports older versions of numpy which works under Python 2. That's doesn't involve any obligations for scikit-learn to work with Python 2. Being more restrictive on supported versions than dependencies is fine IMO.

[chkoar]

Agree. So you propose to drop 3.5 while adding 3.8, right? That should be stated in docs and the CIs should be changed accordingly.

[glemaitre]

Apart from that I believe that we should test against the upstream in the periodic manner otherwise you may get an irrelevant failures in PRs.

CRON job will be your friend

[chkoar]

@glemaitre yeap. I am referring to this.

[chkoar]

Which CI service is preferred for CRON testing?

[chkoar]

Maybe we will try to migrate the existing ones against the nightly/master. Let's see.

[rth]

Which CI service is preferred for CRON testing?

We should probably migrate everything to azure pipelines same as scikit-learn. For now likely Travis CI for CRON.