Scaladoc Support for Capture & Separation Checking (Staging) #23607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4519319 to
3d3caf7
Compare
|
I think it's ready now. |
hamzaremmal
approved these changes
Aug 14, 2025
| @@ -144,5 +144,8 @@ class ScaladocSettings extends SettingGroup with AllScalaSettings: | |||
| val dynamicSideMenu: Setting[Boolean] = | |||
| BooleanSetting(RootSetting, "dynamic-side-menu", "Generate side menu via JS instead of embedding it in every html file", false) | |||
|
|
|||
| val suppressCC: Setting[Boolean] = | |||
| BooleanSetting(RootSetting, "suppressCC", "Suppress rendering anything related to experimental capture checking", false) | |||
There was a problem hiding this comment.
For consistency, I suggest changing the setting to suppress-cc or Yno-cc. No other setting has capital letters in it.
There was a problem hiding this comment.
Can be done when refactoring
This was referenced Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the staging version of #23471 to be merged into main.
Fixes #23437