Align with Scala 3: Add -Xsource-features:double-definitions to warn or error for double definitions
#10846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7f21589 to
25c521f
Compare
lrytz
approved these changes
Aug 16, 2024
-Xsource-features:double-definitions to warn or error for double definitions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optionally warn or error for double definitions that went undetected in Scala 2.
The new condition is a source feature, so it warns under
-Xsource:3and errors under-Xsource-features:double-definitions. It is also available under-Xsource-features:v2.13.15.This is for "user convenience": fixing the bug outright would require users to change code that is probably benign.
Revises the earlier #10727