Skip to content

[Fixed] Bootloader v0.9.17 seems to be broken on Rust nightly-2021-05-20 #167

Closed
@phil-opp

Description

@phil-opp
Member

I just noticed this in the automated CI runs for the blog_os project: https://github.com/phil-opp/blog_os/runs/2626134888?check_suite_focus=true#step:12:47

When trying to run cargo +nightly-2021-05-20 run, the following error occurs:

image

The error message is "Failed to load rest of bootloader" and happens in the early assembly stages.

I'm not sure what's going wrong yet, I will update this issue when I find the cause.

Activity

pinned this issue on May 20, 2021
changed the title [-]Bootloader v0.9.17 seems to be broken on nightly-2021-05-20[/-] [+]Bootloader `v0.9.17` seems to be broken on Rust `nightly-2021-05-20`[/+] on May 20, 2021
phil-opp

phil-opp commented on May 20, 2021

@phil-opp
MemberAuthor

Diff between the working and broken nightly: rust-lang/rust@4e3e6db...f94942d

bjorn3

bjorn3 commented on May 20, 2021

@bjorn3
Contributor

--gc-sections is now only passed if "linker-is-gnu": true is used inside the target spec (rust-lang/rust#85274). The blog os target spec doesn't mention it. Maybe the first stage is too big without --gc-sections?

phil-opp

phil-opp commented on May 20, 2021

@phil-opp
MemberAuthor

@bjorn3 Ah thanks, I think that's likely the reason. I'll push a fix in a moment.

phil-opp

phil-opp commented on May 20, 2021

@phil-opp
MemberAuthor

I opened #168 with a fix.

changed the title [-]Bootloader `v0.9.17` seems to be broken on Rust `nightly-2021-05-20`[/-] [+][Fixed] Bootloader `v0.9.17` seems to be broken on Rust `nightly-2021-05-20`[/+] on May 20, 2021
phil-opp

phil-opp commented on May 20, 2021

@phil-opp
MemberAuthor

Fix published as v0.9.18. A cargo update -p bootloader should be enough to fix this issue in downstream crates.

unpinned this issue on Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    nightly-breakageCode is broken on the latest Rust nightly

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @phil-opp@bjorn3

        Issue actions

          [Fixed] Bootloader `v0.9.17` seems to be broken on Rust `nightly-2021-05-20` · Issue #167 · rust-osdev/bootloader