Missing label in a ping definition causes the ping to fail

[jieyouxu]

E.g. rust-lang/rust#140966 (comment), seems like @rustbot ping rfl is not working (at least sometimes?).

[jieyouxu]

Or maybe it's just the rfl alias? The actual marker-team in team is called rust-for-linux.

[ehuss]

The label for that ping does not exist:

Unknown labels: O-rfl

Perhaps it should be A-rust-for-linux?

[jieyouxu]

Weird. Let me double check.

[jieyouxu]

You're right -- both the labels referenced are outdated in triagebot.toml and also in rustc-dev-guide docs. rust-lang/rust#141139 should fix both and thus close this issue.

I do wonder if it might make sense for triagebot to loudly complain if a ping group becomes misconfigured? Idk, it's hard to figure out why it's not working otherwise.

[ehuss]

There is very basic validation done in https://github.com/rust-lang/triagebot//blob/HEAD/src/handlers/validate_config.rs. It sounds reasonable to me to continue extending that to check things like "does label exist". I think it should be fine to add that in terms of API points and time budget as long as we don't go overboard.

It also seems reasonable to me to have the ping handler just log errors about missing labels, but otherwise continue to process the ping (instead of just stopping).

Those should be relatively easy changes if anyone is interested in trying.