Skip to content

Rewrite dead-code pass to avoid fetching HIR. #98402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 1, 2022
Merged

Rewrite dead-code pass to avoid fetching HIR. #98402

merged 5 commits into from
Jul 1, 2022

Conversation

cjgillot
Copy link
Contributor

This allows to get a more uniform handling of spans, and to simplify the grouping of diagnostics for variants and fields.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 22, 2022
@rust-highfive
Copy link
Contributor

r? @michaelwoerister

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 22, 2022
@cjgillot
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 22, 2022
@bors
Copy link
Collaborator

bors commented Jun 22, 2022

⌛ Trying commit a185c1ebb62a5a85e285571f3766e8e00d5958aa with merge 92403c5c23e9096e4f1d649efcbbc420417c50ea...

@bors
Copy link
Collaborator

bors commented Jun 22, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 22, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@cjgillot
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@bors
Copy link
Collaborator

bors commented Jun 23, 2022

⌛ Trying commit 2d82234 with merge dc937e8637905dcb17a7caf07cff467dc137a826...

@bors
Copy link
Collaborator

bors commented Jun 23, 2022

☀️ Try build successful - checks-actions
Build commit: dc937e8637905dcb17a7caf07cff467dc137a826 (dc937e8637905dcb17a7caf07cff467dc137a826)

@rust-timer
Copy link
Collaborator

Queued dc937e8637905dcb17a7caf07cff467dc137a826 with parent 4334739, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (dc937e8637905dcb17a7caf07cff467dc137a826): comparison url.

Instruction count

  • Primary benchmarks: 🎉 relevant improvements found
  • Secondary benchmarks: 🎉 relevant improvements found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 -0.3% -0.4% 2
Improvements 🎉
(secondary)		 -0.7% -0.8% 6
All 😿🎉 (primary) -0.3% -0.4% 2

Max RSS (memory usage)

Results
  • Primary benchmarks: 😿 relevant regressions found
  • Secondary benchmarks: 😿 relevant regression found
mean1 max count2
Regressions 😿
(primary)		 2.6% 3.0% 2
Regressions 😿
(secondary)		 1.5% 1.5% 1
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) 2.6% 3.0% 2

Cycles

Results
  • Primary benchmarks: 😿 relevant regressions found
  • Secondary benchmarks: 🎉 relevant improvement found
mean1 max count2
Regressions 😿
(primary)		 6.1% 9.4% 7
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 -2.0% -2.0% 1
All 😿🎉 (primary) 6.1% 9.4% 7

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2 ↩3

  2. number of relevant changes ↩ ↩2 ↩3

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jun 24, 2022
@cjgillot cjgillot marked this pull request as ready for review June 24, 2022 05:58
@cjgillot cjgillot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 24, 2022
@michaelwoerister
Copy link
Member

Thanks for the PR, @cjgillot! I'll take a look shortly.

@michaelwoerister
Copy link
Member

I did a first pass over the PR and it looks very good. But it's a big diff, so I'm going to do a second pass tomorrow (especially over 02a42ff).

@michaelwoerister
Copy link
Member

OK, this looks good to me. Thanks, @cjgillot!

@bors r+

@cjgillot
Copy link
Contributor Author

@bors ping

@bors
Copy link
Collaborator

bors commented Jun 30, 2022

😪 I'm awake I'm awake

@cjgillot
Copy link
Contributor Author

@bors r=michaelwoerister

@bors
Copy link
Collaborator

bors commented Jun 30, 2022

📌 Commit 2d82234 has been approved by michaelwoerister

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 30, 2022
@bors
Copy link
Collaborator

bors commented Jul 1, 2022

⌛ Testing commit 2d82234 with merge 5b9775f...

@bors
Copy link
Collaborator

bors commented Jul 1, 2022

☀️ Test successful - checks-actions
Approved by: michaelwoerister
Pushing 5b9775f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 1, 2022
@bors bors merged commit 5b9775f into rust-lang:master Jul 1, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 1, 2022
@bors bors mentioned this pull request Jul 1, 2022
Closed
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (5b9775f): comparison url.

Instruction count

  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 😿 relevant regressions found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 1.5% 1.5% 2
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) N/A N/A 0

Max RSS (memory usage)

Results
  • Primary benchmarks: 🎉 relevant improvement found
  • Secondary benchmarks: mixed results
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 3.1% 3.6% 2
Improvements 🎉
(primary)		 -2.1% -2.1% 1
Improvements 🎉
(secondary)		 -2.5% -3.2% 3
All 😿🎉 (primary) -2.1% -2.1% 1

Cycles

Results
  • Primary benchmarks: 🎉 relevant improvement found
  • Secondary benchmarks: 😿 relevant regression found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 3.1% 3.1% 1
Improvements 🎉
(primary)		 -3.5% -3.5% 1
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) -3.5% -3.5% 1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2 ↩3

  2. number of relevant changes ↩ ↩2 ↩3

@cjgillot cjgillot deleted the undead branch July 1, 2022 20:30
@inquisitivecrystal inquisitivecrystal mentioned this pull request Sep 25, 2022
Open
@clubby789 clubby789 mentioned this pull request Feb 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@michaelwoerister michaelwoerister

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.64.0
Development

Successfully merging this pull request may close these issues.
7 participants
@cjgillot @rust-highfive @rust-timer @bors @rust-log-analyzer @michaelwoerister @rustbot