Skip to content

error_codes: uniformly comment error codes #90616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

mathstuf
Copy link
Contributor

@mathstuf mathstuf commented Nov 5, 2021

No description provided.

@rust-highfive
Copy link
Contributor

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

@rust-highfive
Copy link
Contributor

r? @matthewjasper

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 5, 2021
@GuillaumeGomez
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 5, 2021

📌 Commit 863e522 has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 5, 2021
@bors
Copy link
Collaborator

bors commented Nov 5, 2021

⌛ Testing commit 863e522 with merge 045612b...

@bors
Copy link
Collaborator

bors commented Nov 5, 2021

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing 045612b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 5, 2021
@bors bors merged commit 045612b into rust-lang:master Nov 5, 2021
@rustbot rustbot added this to the 1.58.0 milestone Nov 5, 2021
@mathstuf mathstuf deleted the error_codes-comment-uniformity branch November 5, 2021 19:23
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (045612b): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants