-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Rename force-warns to force-warn #87346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
You don't need to do anything. Cargo's tests that use this are set up in such a way as to be disabled on rust-lang/rust's CI. After this lands and the next nightly is published, we'll need to update Cargo to the new flag, but I can do that, it should be a trivial change. |
@bors r+ |
📌 Commit 800c5f9 has been approved by |
Rollup of 5 pull requests Successful merges: - rust-lang#81864 (docs: GlobalAlloc: completely replace example with one that works) - rust-lang#87024 (rustdoc: show count of item contents when hidden) - rust-lang#87278 (:arrow_up: rust-analyzer) - rust-lang#87326 (Update cargo) - rust-lang#87346 (Rename force-warns to force-warn) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This might have introduced an issue reported to me on twitter:
|
For a little context on @estebank 's quote of my tweet: I had been attempting to run |
Just opened: rust-lang/cargo#9714. |
Changes rustc argument from `--force-warns` to `--force-warn` The rustc argument was renamed in rust-lang/rust#87346 breaking `cargo fix` on the nightly toolchain. I encountered this while attempting to test Edition 2021 migrations. I ran `RUSTC=/path/to/nightly/rustc cargo test` and encountered a few failing tests, but none of them seemed at all related to the 1 line I changed, so if they crop up in CI as well, would love some help on identifying what's causing that. Closes rust-lang/rust#87360
The renames the
--force-warns
option to--force-warn
. This mirrors other lint options like--warn
and--deny
which are in the singular.r? @nikomatsakis
cc @ehuss - this option is being used by Cargo. How do we make sure the transition to using the new name is as smooth as possible?