Skip to content

Rename force-warns to force-warn #87346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2021
Merged

Conversation

rylev
Copy link
Member

@rylev rylev commented Jul 21, 2021

The renames the --force-warns option to --force-warn. This mirrors other lint options like --warn and --deny which are in the singular.

r? @nikomatsakis

cc @ehuss - this option is being used by Cargo. How do we make sure the transition to using the new name is as smooth as possible?

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 21, 2021
@ehuss
Copy link
Contributor

ehuss commented Jul 21, 2021

How do we make sure the transition to using the new name is as smooth as possible?

You don't need to do anything. Cargo's tests that use this are set up in such a way as to be disabled on rust-lang/rust's CI. After this lands and the next nightly is published, we'll need to update Cargo to the new flag, but I can do that, it should be a trivial change.

@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 21, 2021

📌 Commit 800c5f9 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 21, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 21, 2021
Rollup of 5 pull requests

Successful merges:

 - rust-lang#81864 (docs: GlobalAlloc: completely replace example with one that works)
 - rust-lang#87024 (rustdoc: show count of item contents when hidden)
 - rust-lang#87278 (:arrow_up: rust-analyzer)
 - rust-lang#87326 (Update cargo)
 - rust-lang#87346 (Rename force-warns to force-warn)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 43e2575 into rust-lang:master Jul 21, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jul 21, 2021
@estebank
Copy link
Contributor

This might have introduced an issue reported to me on twitter:

Hmm.... so I'm getting the "force-warns" error, even on a freshly "cargo init"'d packages: both binary and library.

I can build and run fine (even when I run cargo +nightly run [not pictured]), and I have today's nightly per rustup.

I'll sleep on it and then file an issue.

@PTNobel
Copy link

PTNobel commented Jul 22, 2021

For a little context on @estebank 's quote of my tweet: I had been attempting to run cargo +nightly fix --edition. I'll try and fix the issue in Cargo now.

@PTNobel
Copy link

PTNobel commented Jul 22, 2021

Just opened: rust-lang/cargo#9714.

@rylev rylev deleted the rename-force-warn branch July 22, 2021 10:27
bors added a commit to rust-lang/cargo that referenced this pull request Jul 22, 2021
Changes rustc argument from `--force-warns` to `--force-warn`

The rustc argument was renamed in rust-lang/rust#87346 breaking `cargo fix` on the nightly toolchain.

I encountered this while attempting to test Edition 2021 migrations.

I ran `RUSTC=/path/to/nightly/rustc cargo test` and encountered a few failing tests, but none of them seemed at all related to the 1 line I changed, so if they crop up in CI as well, would love some help on identifying what's causing that.

Closes rust-lang/rust#87360
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants