Refactor type combining to use default methods. Woohoo! #8669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the "super_*" functions from typeck::infer::combine, and adds them as default methods on the Combine trait instead, making it possible to remove a lot of boilerplate from the various impls of Combine. I've been wanting to do this for over a year. In fact, it was my original motivation for default methods! It might be possible to tighten things up even more, but this is the bulk of it.
|
that's a pretty hot diffstat for just moving some code around |
bors
added a commit
that referenced
this pull request
Aug 22, 2013
This commit removes the "super_*" functions from typeck::infer::combine, and adds them as default methods on the Combine trait instead, making it possible to remove a lot of boilerplate from the various impls of Combine. I've been wanting to do this for over a year. In fact, it was my original motivation for default methods! It might be possible to tighten things up even more, but this is the bulk of it.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 21, 2022
…nce, r=xFrednet fix comments in test for split_once This PR fixed comments in test. `split_once` was stabilized in 1.52, so I think the comments maybe be wrong. ref: https://doc.rust-lang.org/std/string/struct.String.html#method.split_once thank you in advance. changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the "super_*" functions from
typeck::infer::combine, and adds them as default methods on the
Combine trait instead, making it possible to remove a lot of
boilerplate from the various impls of Combine.
I've been wanting to do this for over a year. In fact, it was my
original motivation for default methods!
It might be possible to tighten things up even more, but this is the
bulk of it.