Skip to content

Iterate on DefId for variances and generics. #83166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 18, 2021
Merged

Conversation

cjgillot
Copy link
Contributor

Split from #80347

@rust-highfive
Copy link
Contributor

r? @oli-obk

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 15, 2021
@cjgillot
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 15, 2021
@bors
Copy link
Collaborator

bors commented Mar 15, 2021

⌛ Trying commit 219f0420a7ccb62ef3a7972c7d5ad1d5363da95a with merge a34034dcdfcde56e525766fafd5e72544cee4422...

@bors
Copy link
Collaborator

bors commented Mar 15, 2021

☀️ Try build successful - checks-actions
Build commit: a34034dcdfcde56e525766fafd5e72544cee4422 (a34034dcdfcde56e525766fafd5e72544cee4422)

@rust-timer
Copy link
Collaborator

Queued a34034dcdfcde56e525766fafd5e72544cee4422 with parent 2ccf063, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (a34034dcdfcde56e525766fafd5e72544cee4422): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 16, 2021
@jackh726
Copy link
Member

Slight increase in perf aside: I'm not really sure how I feel about this change :) It seems much less clear what's going on.

@oli-obk
Copy link
Contributor

oli-obk commented Mar 18, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 18, 2021
@bors
Copy link
Collaborator

bors commented Mar 18, 2021

⌛ Trying commit fcd6f20 with merge 83dadca4f0a32393b3b65b611485b2b81cf09258...

@bors
Copy link
Collaborator

bors commented Mar 18, 2021

☀️ Try build successful - checks-actions
Build commit: 83dadca4f0a32393b3b65b611485b2b81cf09258 (83dadca4f0a32393b3b65b611485b2b81cf09258)

@rust-timer
Copy link
Collaborator

Queued 83dadca4f0a32393b3b65b611485b2b81cf09258 with parent 2aafe45, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (83dadca4f0a32393b3b65b611485b2b81cf09258): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 18, 2021
@oli-obk
Copy link
Contributor

oli-obk commented Mar 18, 2021

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 18, 2021

📌 Commit fcd6f20 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2021
@bors
Copy link
Collaborator

bors commented Mar 18, 2021

⌛ Testing commit fcd6f20 with merge 9d0446f...

@bors
Copy link
Collaborator

bors commented Mar 18, 2021

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 9d0446f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 18, 2021
@bors bors merged commit 9d0446f into rust-lang:master Mar 18, 2021
@rustbot rustbot added this to the 1.52.0 milestone Mar 18, 2021
@cjgillot cjgillot deleted the defkey-vge branch March 18, 2021 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants