-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Iterate on DefId for variances and generics. #83166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @oli-obk (rust-highfive has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 219f0420a7ccb62ef3a7972c7d5ad1d5363da95a with merge a34034dcdfcde56e525766fafd5e72544cee4422... |
☀️ Try build successful - checks-actions |
Queued a34034dcdfcde56e525766fafd5e72544cee4422 with parent 2ccf063, future comparison URL. |
Finished benchmarking try commit (a34034dcdfcde56e525766fafd5e72544cee4422): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
Slight increase in perf aside: I'm not really sure how I feel about this change :) It seems much less clear what's going on. |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit fcd6f20 with merge 83dadca4f0a32393b3b65b611485b2b81cf09258... |
☀️ Try build successful - checks-actions |
Queued 83dadca4f0a32393b3b65b611485b2b81cf09258 with parent 2aafe45, future comparison URL. |
Finished benchmarking try commit (83dadca4f0a32393b3b65b611485b2b81cf09258): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
@bors r+ |
📌 Commit fcd6f20 has been approved by |
☀️ Test successful - checks-actions |
Split from #80347