-
Notifications
You must be signed in to change notification settings - Fork 13.3k
[WIP] Jemalloc updated to tikv-jemalloc-sys #82389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Reference PR for measurements with the latest stable Edit: At this point possible free-changes look difficult, as they would need non-standard API calls, which do not match well with global allocator functionality. |
This would need bors try run for reference. |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit ebc9533 with merge 029e25f8d5fcc8d7794c739999f25890290f416b... |
☀️ Try build successful - checks-actions |
Queued 029e25f8d5fcc8d7794c739999f25890290f416b with parent fe1bf8e, future comparison URL. |
Finished benchmarking try commit (029e25f8d5fcc8d7794c739999f25890290f416b): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
Jemalloc updated to tikv-jemalloc-sys for latest jemalloc stable as a reference.