Skip to content

[WIP] Jemalloc updated to tikv-jemalloc-sys #82389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jq-rs
Copy link

@jq-rs jq-rs commented Feb 22, 2021

Jemalloc updated to tikv-jemalloc-sys for latest jemalloc stable as a reference.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 22, 2021
@jq-rs jq-rs marked this pull request as draft February 22, 2021 07:42
@jq-rs
Copy link
Author

jq-rs commented Feb 22, 2021

Reference PR for measurements with the latest stable jemalloc as requested in #81782. Possible free-changes are not included yet.

Edit: At this point possible free-changes look difficult, as they would need non-standard API calls, which do not match well with global allocator functionality.

@jq-rs
Copy link
Author

jq-rs commented Feb 22, 2021

This would need bors try run for reference.

@Xanewok
Copy link
Member

Xanewok commented Feb 24, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 24, 2021
@bors
Copy link
Collaborator

bors commented Feb 24, 2021

⌛ Trying commit ebc9533 with merge 029e25f8d5fcc8d7794c739999f25890290f416b...

@bors
Copy link
Collaborator

bors commented Feb 24, 2021

☀️ Try build successful - checks-actions
Build commit: 029e25f8d5fcc8d7794c739999f25890290f416b (029e25f8d5fcc8d7794c739999f25890290f416b)

@rust-timer
Copy link
Collaborator

Queued 029e25f8d5fcc8d7794c739999f25890290f416b with parent fe1bf8e, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (029e25f8d5fcc8d7794c739999f25890290f416b): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 24, 2021
@jq-rs jq-rs closed this Feb 24, 2021
@jq-rs jq-rs deleted the jq-rs/tikv-jemalloc-sys-update branch February 24, 2021 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants