Update the version ordering algorithm to semver 2.0.0. #7726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@omasanori re: Ord, that's fine, we have a TotalOrd trait which is separate. Yes, Can you add tests that ensure the build metadata is correctly ignored, rather than removing them altogether? |
|
@cmr I see. I've removed the tests because corresponding tests are removed in the spec, but I'll add them in tests for lt, le and so on. |
Note that Version's `le` is not "less than or equal to" now, since `lt` ignores build metadata. I think the new ordering algorithm satisfies strict weak ordering which C++ STL requires, instead of strict total ordering.
bors
added a commit
that referenced
this pull request
Jul 16, 2013
The Ord impl of Version refered to the algorithm in release candidate versions of semver. [Semantic Versioning 2.0.0](http://semver.org/spec/v2.0.0.html) says, "Build metadata SHOULD be ignored when determining version precedence." Note that Version's `le` is not "less than or equal to" now, since `lt` ignores build metadata. I think the new ordering algorithm satisfies strict weak ordering which C++ STL requires, instead of strict total ordering. BTW, is `a || b || ... || x`-style code better or idiomatic in Rust than `if a { return true; } if b { return true; } ... if x { return true; } return false;`-style one?
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Nov 4, 2021
…ip1995 Unseparated literal suffix Closes rust-lang#7658 Since `literal_suffix` style is opinionated, we should disable by default and only enforce if it's stated as so. changelog: [`unseparated_literal_suffix`] is renamed to `literal_suffix`, adds a new configuration `literal-suffix-style` to enforce a certain style writing literal_suffix. Possible values for `literal-suffix-style`: `"separated"`, `"unseparated"`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Ord impl of Version refered to the algorithm in release candidate versions of semver. Semantic Versioning 2.0.0 says, "Build metadata SHOULD be ignored when determining version precedence."
Note that Version's
leis not "less than or equal to" now, sinceltignores build metadata. I think the new ordering algorithm satisfies strict weak ordering which C++ STL requires, instead of strict total ordering.BTW, is
a || b || ... || x-style code better or idiomatic in Rust thanif a { return true; } if b { return true; } ... if x { return true; } return false;-style one?