Skip to content

doc: Reword deprecation message of MetadataExt::as_raw_stat #63327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2019

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Aug 6, 2019

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 6, 2019
@tesuji tesuji force-pushed the fix-as_raw_stat-dep-msg branch from ab6dc5f to 456e455 Compare August 6, 2019 13:31
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with nit fixed

@tesuji tesuji changed the title doc: Rework deprecation message of MetadataExt::as_raw_stat doc: Reword deprecation message of MetadataExt::as_raw_stat Aug 6, 2019
@tesuji tesuji force-pushed the fix-as_raw_stat-dep-msg branch from 456e455 to 031cc32 Compare August 6, 2019 13:32
@tesuji
Copy link
Contributor Author

tesuji commented Aug 7, 2019

The CI is passed.

@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 7, 2019

📌 Commit 031cc32 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 7, 2019
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Aug 7, 2019
…ark-Simulacrum

doc: Reword deprecation message of MetadataExt::as_raw_stat

Closes rust-lang#62711
r? @Mark-Simulacrum
Centril added a commit to Centril/rust that referenced this pull request Aug 8, 2019
…ark-Simulacrum

doc: Reword deprecation message of MetadataExt::as_raw_stat

Closes rust-lang#62711
r? @Mark-Simulacrum
Centril added a commit to Centril/rust that referenced this pull request Aug 8, 2019
…ark-Simulacrum

doc: Reword deprecation message of MetadataExt::as_raw_stat

Closes rust-lang#62711
r? @Mark-Simulacrum
bors added a commit that referenced this pull request Aug 8, 2019
Rollup of 7 pull requests

Successful merges:

 - #62994 (Add test for #43398)
 - #63259 (Add tests for some issues)
 - #63327 (doc: Reword deprecation message of MetadataExt::as_raw_stat)
 - #63331 (Test conditional initialization validation in async fns)
 - #63334 (Update to rustc-guide that passes toolstate)
 - #63353 (Update books)
 - #63360 (Use consistent capitalization in -C/-Z help)

Failed merges:

r? @ghost
@bors bors merged commit 031cc32 into rust-lang:master Aug 8, 2019
@bors
Copy link
Collaborator

bors commented Aug 8, 2019

☔ The latest upstream changes (presumably #63371) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 8, 2019
@tesuji tesuji deleted the fix-as_raw_stat-dep-msg branch August 8, 2019 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Which is accessor method of MetadataExt?
4 participants