-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Use lld directly for Fuchsia target #55106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
@bors r+ |
📌 Commit 1ce8118462fcbc0c2bc69adaadee1f289f4cf449 has been approved by |
@bors r- Failed in rollup #55171 (comment):
|
1ce8118
to
544675f
Compare
@bors r+ |
📌 Commit 544675f53abc58d4122c429cabb3e25a1d6a2b31 has been approved by |
⌛ Testing commit 544675f53abc58d4122c429cabb3e25a1d6a2b31 with merge 3fc42611b7473e09e41f011c9da02293c9a7abc0... |
💔 Test failed - status-travis |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
544675f
to
8e2b70e
Compare
@bors r+ |
📌 Commit 8e2b70e269df1584675edc8246e51fcc28301221 has been approved by |
This is still failing for me locally when building the container but I'm looking into it. |
@bors r- |
Fuchsia already uses lld as the default linker, so there's no reason to always invoke it through Clang, instead we can simply invoke lld directly and pass the set of flags that matches Clang.
8e2b70e
to
3d27aca
Compare
This should be working now. |
@bors: r+ delegate+ |
✌️ @petrhosek can now approve this pull request |
📌 Commit 3d27aca has been approved by |
Use lld directly for Fuchsia target Fuchsia already uses lld as the default linker, so there's no reason to always invoke it through Clang, instead we can simply invoke lld directly and pass the set of flags that matches Clang.
☀️ Test successful - status-appveyor, status-travis |
Fuchsia already uses lld as the default linker, so there's no reason
to always invoke it through Clang, instead we can simply invoke lld
directly and pass the set of flags that matches Clang.