Skip to content

rustdoc: Fix the strip-hidden ImplStripper #33074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2016
Merged

Conversation

mitaa
Copy link
Contributor

@mitaa mitaa commented Apr 18, 2016

Instead of stripping impls which reference stripped items, we keep impls which reference retained items. We do this because when we strip an item we immediately return, and do not recurse into it - leaving the contained items non-stripped from the point of view of the ImplStripper.

fixes #33069

r? @alexcrichton

Instead of stripping impls which reference *stripped* items, we keep impls
which reference *retained* items. We do this because when we strip an
item we immediately return, and do not recurse into it - leaving the
contained items non-stripped from the point of view of the `ImplStripper`.
@alexcrichton
Copy link
Member

@bors: r+ 574450a

@alexcrichton
Copy link
Member

Thanks!

@bors
Copy link
Collaborator

bors commented Apr 21, 2016

⌛ Testing commit 574450a with merge ed57b02...

@bors
Copy link
Collaborator

bors commented Apr 21, 2016

💔 Test failed - auto-win-msvc-32-opt

@alexcrichton
Copy link
Member

@bors: retry

On Thu, Apr 21, 2016 at 1:24 AM, bors [email protected] wrote:

[image: 💔] Test failed - auto-win-msvc-32-opt
http://buildbot.rust-lang.org/builders/auto-win-msvc-32-opt/builds/3084


You are receiving this because you were assigned.
Reply to this email directly or view it on GitHub
#33074 (comment)

@bors
Copy link
Collaborator

bors commented Apr 21, 2016

⌛ Testing commit 574450a with merge b5ba592...

bors added a commit that referenced this pull request Apr 21, 2016
rustdoc: Fix the strip-hidden `ImplStripper`

Instead of stripping impls which reference *stripped* items, we keep impls which reference *retained* items. We do this because when we strip an item we immediately return, and do not recurse into it - leaving the contained items non-stripped from the point of view of the `ImplStripper`.

fixes #33069

r? @alexcrichton
@bors
Copy link
Collaborator

bors commented Apr 21, 2016

💔 Test failed - auto-win-msvc-64-opt

@alexcrichton
Copy link
Member

@bors: retry

On Thu, Apr 21, 2016 at 10:54 AM, bors [email protected] wrote:

[image: 💔] Test failed - auto-win-msvc-64-opt
http://buildbot.rust-lang.org/builders/auto-win-msvc-64-opt/builds/3885


You are receiving this because you were assigned.
Reply to this email directly or view it on GitHub
#33074 (comment)

@bors bors merged commit 574450a into rust-lang:master Apr 21, 2016
@mitaa mitaa deleted the rdoc-irlst branch April 22, 2016 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rustdoc: local doc(hidden) type shows in implementors section
3 participants