-
Notifications
You must be signed in to change notification settings - Fork 13.3k
rustdoc: Fix the strip-hidden ImplStripper
#33074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Instead of stripping impls which reference *stripped* items, we keep impls which reference *retained* items. We do this because when we strip an item we immediately return, and do not recurse into it - leaving the contained items non-stripped from the point of view of the `ImplStripper`.
Thanks! |
⌛ Testing commit 574450a with merge ed57b02... |
💔 Test failed - auto-win-msvc-32-opt |
@bors: retry On Thu, Apr 21, 2016 at 1:24 AM, bors [email protected] wrote:
|
rustdoc: Fix the strip-hidden `ImplStripper` Instead of stripping impls which reference *stripped* items, we keep impls which reference *retained* items. We do this because when we strip an item we immediately return, and do not recurse into it - leaving the contained items non-stripped from the point of view of the `ImplStripper`. fixes #33069 r? @alexcrichton
💔 Test failed - auto-win-msvc-64-opt |
@bors: retry On Thu, Apr 21, 2016 at 10:54 AM, bors [email protected] wrote:
|
Instead of stripping impls which reference stripped items, we keep impls which reference retained items. We do this because when we strip an item we immediately return, and do not recurse into it - leaving the contained items non-stripped from the point of view of the
ImplStripper
.fixes #33069
r? @alexcrichton