Skip to content

Fix MIR text output for terminators since they were wrapped in Option. #30771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2016
Merged

Fix MIR text output for terminators since they were wrapped in Option. #30771

merged 1 commit into from
Jan 11, 2016

Conversation

solson
Copy link
Member

@solson solson commented Jan 7, 2016

This just removes the Some() that appeared around terminators in MIR text output after #30481 (cc @nagisa). The graphviz is already fixed.

r? @eddyb

@eddyb
Copy link
Member

eddyb commented Jan 7, 2016

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 7, 2016

📌 Commit 8e29367 has been approved by eddyb

@bors
Copy link
Collaborator

bors commented Jan 8, 2016

⌛ Testing commit 8e29367 with merge 01c86ea...

bors added a commit that referenced this pull request Jan 8, 2016
This just removes the `Some()` that appeared around terminators in MIR text output after #30481 (cc @nagisa). The graphviz is already fixed.

r? @eddyb
@bors
Copy link
Collaborator

bors commented Jan 8, 2016

💔 Test failed - auto-mac-64-opt

@nrc
Copy link
Member

nrc commented Jan 8, 2016

@bors retry

@bors
Copy link
Collaborator

bors commented Jan 8, 2016

💔 Test failed - auto-linux-32-nopt-t

@solson
Copy link
Member Author

solson commented Jan 8, 2016

Yet another timeout failure. This commit is simple enough and the tests passed on other platforms, so it could probably just be rolled up.

@brson
Copy link
Contributor

brson commented Jan 8, 2016

@bors rollup

@brson
Copy link
Contributor

brson commented Jan 8, 2016

@bors retry

nagisa added a commit to nagisa/rust that referenced this pull request Jan 9, 2016
This just removes the `Some()` that appeared around terminators in MIR text output after rust-lang#30481 (cc @nagisa). The graphviz is already fixed.

r? @eddyb
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jan 9, 2016
This just removes the `Some()` that appeared around terminators in MIR text output after rust-lang#30481 (cc @nagisa). The graphviz is already fixed.

r? @eddyb
bors added a commit that referenced this pull request Jan 11, 2016
@bors bors merged commit 8e29367 into rust-lang:master Jan 11, 2016
@solson solson deleted the mir-text-terminator-fix branch January 15, 2016 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants