Skip to content

Made dynamic_lib migration path more explicit #30465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 25, 2015
Merged

Conversation

androm3da
Copy link
Contributor

The dynamic_lib library has been deprecated in favor of contents on crates.io, but apparently libloading is a more specific direction that fits the need.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@durka
Copy link
Contributor

durka commented Dec 18, 2015

If the crate is good enough to recommend in the deprecation message, should it be a candidate for inclusion in the nursery?

@steveklabnik
Copy link
Member

Yes, I would argue that this should point to the literal out of tree crate rather than picking a "better" one

@androm3da
Copy link
Contributor Author

By "literal out of tree crate" do you mean that dynamic_lib is now hosted on crates.io? Or maybe that's just the plan?

@androm3da
Copy link
Contributor Author

@steveklabnik Ok I will change it to dylib -- I think it wasn't in crates.io when I first looked, or I just didn't find it.

@alexcrichton
Copy link
Member

@bors: r+ a8df425 rollup

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Dec 23, 2015
The `dynamic_lib` library has been deprecated in favor of contents on crates.io, but apparently `libloading` is a more specific direction that fits the need.
bors added a commit that referenced this pull request Dec 25, 2015
@bors bors merged commit a8df425 into rust-lang:master Dec 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants