configure: test $SHELL's permission #30251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
| if [ -r "/usr/bin/env" ]; then | ||
| BIN_TO_PROBE="/usr/bin/env" | ||
| else | ||
| err "Cannot determine if Rust should be built for i686 userland, or x86_64" |
There was a problem hiding this comment.
This wasn't an error before but rather it just went ahead with x86_64 (I think), could that be retained?
There was a problem hiding this comment.
Actually i686 would have been picked up, but anyways, I'll demote err to warn.
On some weird setup where $SHELL is a relative path (can happen under GNU Screen,) `file -L "$BIN_TO_PROBE"` fails and $CFG_CPUTYPE is wrongly set to i686. We should not only check its string value but also permission on filesystem.
|
⌛ Testing commit 00e6667 with merge b4d3b6e... |
|
@bors: retry force |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Dec 23, 2015
On some weird setup where $SHELL is a relative path (can happen under GNU Screen,) `file -L "$BIN_TO_PROBE"` fails and $CFG_CPUTYPE is wrongly set to i686. We should not only check its string value but also permission on filesystem.
bors
added a commit
that referenced
this pull request
Dec 25, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some weird setup where $SHELL is a relative path (can happen under GNU
Screen,)
file -L "$BIN_TO_PROBE"fails and $CFG_CPUTYPE is wrongly set toi686. We should not only check its string value but also permission on
filesystem.