Add link to Debug trait #25376
Add link to Debug trait #25376
Conversation
I don't recall reading about this `Debug` trait so far in the book.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
|
Thanks @swaroopch ! I want to make a chapter specifically about display and debug, but until then, this is an improvement for sure. Thanks! |
|
@bors: r+ rollup |
|
📌 Commit baef132 has been approved by |
I don't recall reading about this `Debug` trait so far in the book. Please ignore this PR if I have missed that part. r? @steveklabnik
| @@ -181,6 +181,8 @@ match version { | |||
| This function makes use of an enum, `ParseError`, to enumerate the various | |||
| errors that can occur. | |||
|
|
|||
| The [`Debug`](../core/fmt/trait.Debug.html) trait is what let's us print the enum value using the `{:?}` format operation. | |||
There was a problem hiding this comment.
This should be "lets", not "let's", right?
There was a problem hiding this comment.
ah yes, and it probably should be to std, not core.
@swaroopch , up for a second PR after this one lands? heh. It's already being tested in the rollup, or i'd say fix it first
There was a problem hiding this comment.
@sfackler @steveklabnik I added a second commit to same branch in my fork - f6e5369 - but I'm a bit confused on how this works - should I do a separate PR?
There was a problem hiding this comment.
Ah! so, #25377 failed. so no, you don't need to make a new PR
|
@bors: r+ rollup |
|
📌 Commit f6e5369 has been approved by |
I don't recall reading about this `Debug` trait so far in the book. Please ignore this PR if I have missed that part. r? @steveklabnik
I don't recall reading about this
Debugtrait so far in the book. Please ignore this PR if I have missed that part.r? @steveklabnik