Skip to content

Add some more error explanations #25328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Conversation

nham
Copy link
Contributor

@nham nham commented May 12, 2015

Adds long diagnostic messages for the following error codes:

  • E0049
  • E0050
  • E0066
  • E0069
  • E0106
  • E0107
  • E0166
  • E0201
  • E0322

cc #24407

@rust-highfive
Copy link
Contributor

r? @pcwalton

(rust_highfive has picked a reviewer for you, use r? to override)

Nick Hamann added 4 commits May 12, 2015 04:18
This also updates the error message to remove mention of "managed
heap", which was removed in 8a91d33.
This error code has been removed.

```
trait Foo {
fn foo(&self, u8) -> bool;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think not naming the parameter here is somewhat rare, could this be given a name?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(ah same for the above fn foo as well)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Nick Hamann added 2 commits May 12, 2015 13:44
I've just added a link instead to the lifetime elision section of
the book.
@alexcrichton
Copy link
Member

@bors: r+ 5c77f0d rollup

Thanks!

steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 13, 2015
Adds long diagnostic messages for the following error codes:

 - E0049
 - E0050
 - E0066
 - E0069
 - E0106
 - E0107
 - E0166
 - E0201
 - E0322

cc rust-lang#24407
@steveklabnik
Copy link
Member

@nham
Copy link
Contributor Author

nham commented May 13, 2015

Maybe? It seems that those tests are looking for a specific error message, and I changed the error message. I'm not completely sure.

@nham
Copy link
Contributor Author

nham commented May 13, 2015

@steveklabnik Sorry about that. I've added an attempted fix. Not tested yet though.

@steveklabnik
Copy link
Member

I'm not 100% sure that it's the cause. If the next one fails, i'll pull in that commit and try again ❤️

@steveklabnik
Copy link
Member

yup, it failed again. cherry-picking that commit, thanks for writing it

@nham
Copy link
Contributor Author

nham commented May 13, 2015

Something seems to be up with this. When I try to run make check-stage1 I get an ICE. I'm closing this PR and splitting it up. First PR is #25363

@nham nham closed this May 13, 2015
Manishearth added a commit to Manishearth/rust that referenced this pull request May 13, 2015
steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants