-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Add some more error explanations #25328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
This also updates the error message to remove mention of "managed heap", which was removed in 8a91d33.
This error code has been removed.
|
||
``` | ||
trait Foo { | ||
fn foo(&self, u8) -> bool; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think not naming the parameter here is somewhat rare, could this be given a name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(ah same for the above fn foo
as well)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
I've just added a link instead to the lifetime elision section of the book.
Adds long diagnostic messages for the following error codes: - E0049 - E0050 - E0066 - E0069 - E0106 - E0107 - E0166 - E0201 - E0322 cc rust-lang#24407
I think this may have borked the rollup: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/4917/steps/test/logs/stdio did it? |
Maybe? It seems that those tests are looking for a specific error message, and I changed the error message. I'm not completely sure. |
@steveklabnik Sorry about that. I've added an attempted fix. Not tested yet though. |
I'm not 100% sure that it's the cause. If the next one fails, i'll pull in that commit and try again ❤️ |
yup, it failed again. cherry-picking that commit, thanks for writing it |
Something seems to be up with this. When I try to run |
Adds long diagnostic messages for the following error codes:
cc #24407