Skip to content

fix an error about the static lifetime #21345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2015
Merged

Conversation

glacjay
Copy link
Contributor

@glacjay glacjay commented Jan 18, 2015

The reference should be x, not FOO itself.

The reference should be `x`, not `FOO` itself.
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@alexcrichton
Copy link
Member

@bors: r+ 2b6efbf rollup

@alexcrichton
Copy link
Member

@glacjay we've got automation (we call @bors) which when we write "r+" will enqueue this PR for testing and merging, once all tests pass this will automatically be merged!

You can check out the queue here: http://buildbot.rust-lang.org/homu/queue/rust

@glacjay
Copy link
Contributor Author

glacjay commented Jan 19, 2015

@alexcrichton Ah ha! That's COOL!

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Jan 19, 2015
The reference should be `x`, not `FOO` itself.
barosl added a commit to barosl/rust that referenced this pull request Jan 20, 2015
The reference should be `x`, not `FOO` itself.
@bors bors merged commit 2b6efbf into rust-lang:master Jan 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants