Fix issue #15826. #16778
Merged
Fix issue #15826. #16778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs a commit message that actually describes what it's doing. |
|
Oops. I added a comment describing the commit. Thanks! |
d8e287e to
89dbc27
Compare
The implemented fix rounds half-way cases away from zero as described in the original comments. This rounding algorithm is sometimes called arithmetic rounding. It is described further here: http://en.wikipedia.org/wiki/Rounding#Round_half_away_from_zero I also added several new tests to prevent regressions.
89dbc27 to
687db5d
Compare
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Aug 29, 2014
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Aug 31, 2014
matthiaskrgr
pushed a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 10, 2024
Update `rustc_pattern_analysis` to 0.42.0 There was an important API change in 0.41.0, and (hopefully) a fix for rust-lang/rust-analyzer#16774 in 0.42.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implemented fix rounds half-way cases away from zero as described in the original comments.
This rounding algorithm is sometimes called arithmetic rounding. It is described further here: http://en.wikipedia.org/wiki/Rounding#Round_half_away_from_zero
I also added several new tests to prevent regressions.