add more TypeFlags fast paths, cache param_env canonicalization
#141451
Conversation
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
[perf] next-solver canonicalization + eager-resolve kinda hacky
|
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (f57ef94): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary -2.4%, secondary -2.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary -34.4%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 776.992s -> 776.925s (-0.01%) |
91ee32e to
c3eaa13
Compare
|
@bors try @rust-timer quue |
|
@rust-timer queue |
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
[perf] next-solver canonicalization + eager-resolve kinda hacky
c3eaa13 to
20a2cd8
Compare
TypeFlags fast paths, cache param_env canonicalization
|
r? @davidtwco rustbot has assigned @davidtwco. Use |
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
TypeFlags fast paths, cache param_env canonicalizationTypeFlags fast paths, cache param_env canonicalization
add additional `TypeFlags` fast paths Some crates, e.g. `diesel`, have items with a lot of where-clauses (more than 150). In these cases checking the `TypeFlags` of the whole `param_env` can be very beneficial. This adds `fn fold_clauses` to mirror the existing `fn visit_clauses` and then uses this in folders which fold `ParamEnv`s. Split out from #141451, depends on #141500. r? `@compiler-errors`
|
☔ The latest upstream changes (presumably #141442) made this pull request unmergeable. Please resolve the merge conflicts. |
add additional `TypeFlags` fast paths Some crates, e.g. `diesel`, have items with a lot of where-clauses (more than 150). In these cases checking the `TypeFlags` of the whole `param_env` can be very beneficial. This adds `fn fold_clauses` to mirror the existing `fn visit_clauses` and then uses this in folders which fold `ParamEnv`s. Split out from #141451, depends on #141442. r? `@compiler-errors`
add additional `TypeFlags` fast paths Some crates, e.g. `diesel`, have items with a lot of where-clauses (more than 150). In these cases checking the `TypeFlags` of the whole `param_env` can be very beneficial. This adds `fn fold_clauses` to mirror the existing `fn visit_clauses` and then uses this in folders which fold `ParamEnv`s. Split out from #141451, depends on #141442. r? `@compiler-errors`
add additional `TypeFlags` fast paths Some crates, e.g. `diesel`, have items with a lot of where-clauses (more than 150). In these cases checking the `TypeFlags` of the whole `param_env` can be very beneficial. This adds `fn fold_clauses` to mirror the existing `fn visit_clauses` and then uses this in folders which fold `ParamEnv`s. Split out from rust-lang/rust#141451, depends on rust-lang/rust#141442. r? `@compiler-errors`
BLocked on #141581