Skip to content

[DO NOT MERGE] what if we don't allow unused filecheck prefixes? #137142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jieyouxu
Copy link
Member

I'm fairly sure this is load-bearing, checking to identify examples where this is necessary.

r? @ghost

try-job: aarch64-gnu
try-job: aarch64-apple
try-job: test-various
try-job: armhf-gnu
try-job: i686-mingw-1
try-job: i686-msvc-1

@rustbot rustbot added A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Feb 16, 2025
@jieyouxu
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 16, 2025
…try>

[DO NOT MERGE] what if we don't allow unused filecheck prefixes?

I'm fairly sure this is load-bearing, checking to identify examples where this is necessary.

r? `@ghost`

try-job: aarch64-gnu
try-job: aarch64-apple
try-job: test-various
try-job: armhf-gnu
try-job: i686-mingw-1
try-job: i686-msvc-1
@bors
Copy link
Collaborator

bors commented Feb 16, 2025

⌛ Trying commit 810d509 with merge 9862d24...

@jieyouxu jieyouxu added S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 16, 2025
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-llvm-18 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
#22 exporting to docker image format
#22 sending tarball 28.1s done
#22 DONE 33.6s
##[endgroup]
Setting extra environment values for docker:  --env ENABLE_GCC_CODEGEN=1 --env GCC_EXEC_PREFIX=/usr/lib/gcc/
[CI_JOB_NAME=x86_64-gnu-llvm-18]
debug: `DISABLE_CI_RUSTC_IF_INCOMPATIBLE` configured.
---
sccache: Starting the server...
##[group]Configure the build
configure: processing command line
configure: 
configure: build.configure-args := ['--build=x86_64-unknown-linux-gnu', '--llvm-root=/usr/lib/llvm-18', '--enable-llvm-link-shared', '--set', 'rust.randomize-layout=true', '--set', 'rust.thin-lto-import-instr-limit=10', '--enable-verbose-configure', '--enable-sccache', '--disable-manage-submodules', '--enable-locked-deps', '--enable-cargo-native-static', '--set', 'rust.codegen-units-std=1', '--set', 'dist.compression-profile=balanced', '--dist-compression-formats=xz', '--set', 'rust.lld=false', '--disable-dist-src', '--release-channel=nightly', '--enable-debug-assertions', '--enable-overflow-checks', '--enable-llvm-assertions', '--set', 'rust.verify-llvm-ir', '--set', 'rust.codegen-backends=llvm,cranelift,gcc', '--set', 'llvm.static-libstdcpp', '--enable-new-symbol-mangling']
configure: target.x86_64-unknown-linux-gnu.llvm-config := /usr/lib/llvm-18/bin/llvm-config
configure: llvm.link-shared     := True
configure: rust.randomize-layout := True
configure: rust.thin-lto-import-instr-limit := 10
---
failures:

---- [mir-opt] tests/mir-opt/optimize_none.rs#NO-OPT stdout ----

error in revision `NO-OPT`: verification with 'FileCheck' failed
status: exit status: 2
command: "/usr/lib/llvm-18/bin/FileCheck" "--input-file" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/mir-opt/optimize_none.NO-OPT/optimize_none.mir" "/checkout/tests/mir-opt/optimize_none.rs" "--check-prefix=CHECK" "--check-prefix" "NO-OPT" "--dump-input-context" "100"
--- stderr -------------------------------
--- stderr -------------------------------
error: no check strings found with prefix 'NO-OPT:'


---- [mir-opt] tests/mir-opt/optimize_none.rs#SPEED-OPT stdout ----


error in revision `SPEED-OPT`: verification with 'FileCheck' failed
status: exit status: 2
command: "/usr/lib/llvm-18/bin/FileCheck" "--input-file" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/mir-opt/optimize_none.SPEED-OPT/optimize_none.mir" "/checkout/tests/mir-opt/optimize_none.rs" "--check-prefix=CHECK" "--check-prefix" "SPEED-OPT" "--dump-input-context" "100"
--- stderr -------------------------------
--- stderr -------------------------------
error: no check strings found with prefix 'SPEED-OPT:'



failures:

@jieyouxu
Copy link
Member Author

jieyouxu commented Feb 16, 2025

Yeah, as expected. They declare a revision but isn't actually used as filecheck annotations.

@rust-log-analyzer
Copy link
Collaborator

The job aarch64-apple failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
Updating files:  98% (50983/52023)
Updating files:  99% (51503/52023)
Updating files: 100% (52023/52023)
Updating files: 100% (52023/52023), done.
Switched to a new branch 'try'
branch 'try' set up to track 'origin/try'.
[command]/opt/homebrew/bin/git log -1 --format=%H
9862d245c00a164f6673ffba98150c16512972ac
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
---
file:.git/config remote.origin.url=https://github.com/rust-lang-ci/rust
file:.git/config remote.origin.fetch=+refs/heads/*:refs/remotes/origin/*
file:.git/config gc.auto=0
file:.git/config http.https://github.com/.extraheader=AUTHORIZATION: basic ***
file:.git/config branch.try.remote=origin
file:.git/config branch.try.merge=refs/heads/try
file:.git/config remote.upstream.fetch=+refs/heads/*:refs/remotes/upstream/*
file:.git/config submodule.library/backtrace.active=true
file:.git/config submodule.library/backtrace.url=https://github.com/rust-lang/backtrace-rs.git
file:.git/config submodule.library/stdarch.active=true
---
failures:

---- [mir-opt] tests/mir-opt/optimize_none.rs#SPEED-OPT stdout ----

error in revision `SPEED-OPT`: verification with 'FileCheck' failed
status: exit status: 2
command: "/Users/runner/work/rust/rust/build/aarch64-apple-darwin/ci-llvm/bin/FileCheck" "--input-file" "/Users/runner/work/rust/rust/build/aarch64-apple-darwin/test/mir-opt/optimize_none.SPEED-OPT/optimize_none.mir" "/Users/runner/work/rust/rust/tests/mir-opt/optimize_none.rs" "--check-prefix=CHECK" "--check-prefix" "SPEED-OPT" "--dump-input-context" "100"
--- stderr -------------------------------
--- stderr -------------------------------
error: no check strings found with prefix 'SPEED-OPT:'


---- [mir-opt] tests/mir-opt/optimize_none.rs#NO-OPT stdout ----


error in revision `NO-OPT`: verification with 'FileCheck' failed
status: exit status: 2
command: "/Users/runner/work/rust/rust/build/aarch64-apple-darwin/ci-llvm/bin/FileCheck" "--input-file" "/Users/runner/work/rust/rust/build/aarch64-apple-darwin/test/mir-opt/optimize_none.NO-OPT/optimize_none.mir" "/Users/runner/work/rust/rust/tests/mir-opt/optimize_none.rs" "--check-prefix=CHECK" "--check-prefix" "NO-OPT" "--dump-input-context" "100"
--- stderr -------------------------------
--- stderr -------------------------------
error: no check strings found with prefix 'NO-OPT:'



failures:

@jieyouxu jieyouxu deleted the exp-no-unused-prefixes branch February 17, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants