rustdoc: dedup search form HTML #124738
Merged
rustdoc: dedup search form HTML #124738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @jsha Some changes occurred in GUI tests. |
83945b8 to
3b8a5f9
Compare
This comment has been minimized.
This comment has been minimized.
3b8a5f9 to
a6cb0b9
Compare
This comment has been minimized.
This comment has been minimized.
This change constructs the search form HTML using JavaScript, instead of plain HTML. It uses a custom element because - the [parser]'s insert algorithm runs the connected callback synchronously, so we won't get layout jank - it requires very little HTML, so it's a real win in size [parser]: https://html.spec.whatwg.org/multipage/parsing.html#create-an-element-for-the-token This shrinks the standard library by about 60MiB, by my test.
a6cb0b9 to
eeb59f1
Compare
| </nav>`; | ||
| } | ||
| } | ||
| window.customElements.define("rustdoc-search", RustdocSearchElement); |
There was a problem hiding this comment.
Didn't know you could do that. Pretty nice!
GuillaumeGomez
approved these changes
May 6, 2024
|
Nice improvement, thanks! @bors r+ rollup |
|
💔 Test failed - checks-actions |
This comment has been minimized.
This comment has been minimized.
|
Failed to push the docker image. @bors retry |
|
@bors r=GuillaumeGomez Allow custom element in HTML5 tidy. |
|
💔 Test failed - checks-actions |
|
@bors retry DNS… |
|
homu still thinks this is in queue for some reason, so trying to talk some reason into it: @bors r- |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change constructs the search form HTML using JavaScript, instead of plain HTML. It uses a custom element because
This shrinks the standard library by about 60MiB, by my test.
There should be no visible changes. Just use less disk space.