Fix overly permissive borrow checking rules for &mut &mut
#10519
Conversation
|
ping @pnkfelix (though I see it's bitrotted) |
| allowed `*x` to be mutated without making the subpaths of `*x` | ||
| inaccessible: worse, they became accessible through a new path (I | ||
| suppose that we could support swap, too, if needed, by moving the | ||
| loans over to the new path). |
There was a problem hiding this comment.
I assume the comments made here about the swap operator solely apply to the feature as implemented at the language level, and that the util::swap library function does not fall victim to it? But then again, that library function is implemented by pretty simplistic looking unsafe code. . . does the type system ensure that the type signature of util::swap suffices to enforce the necessary guarantees here?
If the above is true, you may just want to stress further that you are solely commenting on the <-> operator, not the util::swap function.
|
�Feel free to push with r=pnkfelix after rebasing + fixing above nits. |
…o the first/last item in the slice and modify the slice to exclude the returned item. Useful when writing iterators over mutable references.
| return None; | ||
| } | ||
| let r = if self.remaining2.len() > 0 { | ||
| &mut self.remaining1 |
There was a problem hiding this comment.
Looks like it, yes. Weird that this didn't seem to fail any tests?
be done for at most lifetime `'a` Fixes rust-lang#8624
|
@huonw patched up that problem and improved tests so they would test case where you had a reverse iterator and the data wrapped around. |
See #8624 for details.
r? @pnkfelix