-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Migrate the diagnostics of the rustc_typeck crate #100722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jackh726 (or someone else) soon. Please see the contribution instructions for more information. |
This comment has been minimized.
This comment has been minimized.
☔ The latest upstream changes (presumably #100793) made this pull request unmergeable. Please resolve the merge conflicts. |
r? @davidtwco |
We have a no merge policy, could you remove the merge commits? |
Sure. I am not that experienced with git though... How do I do that? |
git rebase -i (sha before the branches diverged) |
The job Click to see the possible cause of the failure (guessed by this bot)
|
All of this is a bit more complicated than anticipated... Can I just create a new, fresh PR? 😅 |
Yeah, that's fine too. |
Closed in favor of #101007 |
Currently WIP, please don't merge yet.