Skip to content

./x.py test tidy should reject additions of new binary files #98792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
compiler-errors opened this issue Jul 2, 2022 · 1 comment · Fixed by #98793
Closed

./x.py test tidy should reject additions of new binary files #98792

compiler-errors opened this issue Jul 2, 2022 · 1 comment · Fixed by #98793

Comments

@compiler-errors
Copy link
Member

It would be great if the tidy check rejected commits of binary files, such as what happened in #97488 (removed in #98791). Ideally we would have an allowlist of binary files in the repo, so people can't sneak in rogue binaries...

@Mark-Simulacrum
Copy link
Member

https://github.com/rust-lang/rust/blob/master/src/tools/tidy/src/bins.rs is what attempts to check for this -- I'm investigating what went wrong with it.

I think the root cause is that we run tidy on src/, library/ and compiler/, but not any other directories as far as I can tell. That won't cover the root directory, which is obviously a problem. Investigating a fix to that now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants