Skip to content

rustdoc: Move the extra labels to the symbol in tables #86578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dns2utf8 opened this issue Jun 23, 2021 · 7 comments
Closed

rustdoc: Move the extra labels to the symbol in tables #86578

dns2utf8 opened this issue Jun 23, 2021 · 7 comments
Assignees
@dns2utf8
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@dns2utf8
Copy link
Contributor

Currently labels like Deprecated are in the right column far away from the symbol they describe:


I propose we move them to the symbol in the left column.

Cheers,
Stefan

From #85651
@dns2utf8 dns2utf8 mentioned this issue Jun 23, 2021
Merged
@GuillaumeGomez GuillaumeGomez added A-rustdoc-ui Area: Rustdoc UI (generated HTML) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jun 23, 2021
@GuillaumeGomez
Copy link
Member

Do you want to be assigned on it?

@dns2utf8
Copy link
Contributor Author

Yes, please 👍

@GuillaumeGomez
Copy link
Member

Done. :)

@dns2utf8
Copy link
Contributor Author

Thanks! :)

@dns2utf8 dns2utf8 mentioned this issue Jun 24, 2021
Merged
@dns2utf8
Copy link
Contributor Author

I uploaded a demo for the PR: https://data.estada.ch/rustdoc-nightly_2336406b38_2021-06-24/rustdoc_demo/mod1/index.html

bors added a commit to rust-lang-ci/rust that referenced this issue Jun 29, 2021
@bors
Auto merge of rust-lang#86594 - dns2utf8:move_label_to_symbol, r=Guil…
5d0fae5 
…laumeGomez

rustdoc: Move label to symbol

Implements rust-lang#86578 depends on rust-lang#85651

r? `@GuillaumeGomez`

# Screenshot of mobile
![grafik](https://user-images.githubusercontent.com/739070/123267064-1be07f80-d4ec-11eb-8bdb-0b18a41908dc.png)

# Screenshot on desktop
![grafik](https://user-images.githubusercontent.com/739070/123267204-46323d00-d4ec-11eb-97ca-2750421352f4.png)
@dns2utf8
Copy link
Contributor Author

dns2utf8 commented Jul 1, 2021

Implemented with #86594, potentially improved by #86767

@jyn514
Copy link
Member

jyn514 commented Aug 16, 2021

Closing this since it was implemented.

@jyn514 jyn514 closed this as completed Aug 16, 2021
@jsha jsha mentioned this issue Jun 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dns2utf8 dns2utf8

Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dns2utf8 @GuillaumeGomez @jyn514