-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Labels
A-rustdoc-uiArea: Rustdoc UI (generated HTML)Area: Rustdoc UI (generated HTML)C-feature-requestCategory: A feature request, i.e: not implemented / a PR.Category: A feature request, i.e: not implemented / a PR.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.Relevant to the rustdoc team, which will review and decide on the PR/issue.
Description
mdbook v4.6+ has a feature that pressing ESC removes query components from URLs (for example ?highlight=...
).
The feature was implemented in rust-lang/mdBook#1427.
It would be nice if rustdoc offers the same kind of that feature.
This is, for example, an URL that contains query components in rustdoc: https://doc.rust-lang.org/nightly/std/time/struct.Duration.html?search=asdfasdf.
What's the benefit of this feature?
When users share URLs to an API, they don't have to remove the query manually.
Metadata
Metadata
Assignees
Labels
A-rustdoc-uiArea: Rustdoc UI (generated HTML)Area: Rustdoc UI (generated HTML)C-feature-requestCategory: A feature request, i.e: not implemented / a PR.Category: A feature request, i.e: not implemented / a PR.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.Relevant to the rustdoc team, which will review and decide on the PR/issue.
Activity
tesuji commentedon Jan 24, 2021
@GuillaumeGomez, could you share some thoughts about this feature request?
If possible, could you mentor contributors how to implement this ?
GuillaumeGomez commentedon Jan 24, 2021
I think it's a good idea. Gonna take a look at how to do it.
Rollup merge of rust-lang#81379 - GuillaumeGomez:improve-urls, r=Nemo157
tesuji commentedon Jan 29, 2021
Can we reopen this issue ?
I think #81379 only removes the query component when we remove keywords in search bar.
This issue is about adding a keyboard shortcut.
GuillaumeGomez commentedon Jan 29, 2021
Oh I see, my bad. Reopening!
Rollup merge of rust-lang#82234 - GuillaumeGomez:remove-query-param-o…
Rollup merge of rust-lang#82234 - GuillaumeGomez:remove-query-param-o…
Rollup merge of rust-lang#82234 - GuillaumeGomez:remove-query-param-o…