Skip to content

c_void has wrong rustc support level in docs #55619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jethrogb opened this issue Nov 2, 2018 · 4 comments · Fixed by #65930
Closed

c_void has wrong rustc support level in docs #55619

jethrogb opened this issue Nov 2, 2018 · 4 comments · Fixed by #65930
Labels
A-stability Area: `#[stable]`, `#[unstable]` etc.

Comments

@jethrogb
Copy link
Contributor

jethrogb commented Nov 2, 2018

The documentation page for core::ffi::c_void says it's available at version 1.1.0, however, it's only available at version 1.30.0.

@Proximyst
Copy link

While the module c_void lays in, core::ffi, was stabilised at 1.30.0, the type c_void was stabilised at 1.1.0, which again makes the docs correct. The docs for the module core::ffi say 1.30.0.

@jethrogb
Copy link
Contributor Author

jethrogb commented Nov 3, 2018

which again makes the docs correct.

I guess that's a matter of perspective. I think minimum versions of parent items should trickle down to child items such that you don't have to walk up the module tree in the documentation to find out whether something is available or not.

@IsaacWoods
Copy link
Contributor

So I did the original PR to create core::ffi::c_void, and probably agree with @jethrogb in hindsight. The c_void type was originally available at std::os::raw::c_void, which should stay at 1.1.0. However, both std::ffi::c_void and core::ffi::c_void should probably be changed to 1.30.0.

@ExpHP
Copy link
Contributor

ExpHP commented Nov 6, 2018

This has happened before as well: #49651

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-stability Area: `#[stable]`, `#[unstable]` etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants