Compiler suggests import it already has as well as mislabels issue #53430
Assignees
Labels
A-suggestion-diagnostics
Area: Suggestions generated by the compiler applied by `cargo fix`
C-bug
Category: This is a bug.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Comments
Centril
added a commit
to Centril/rust
that referenced
this issue
Feb 13, 2019
Only suggest imports if not imported. Fixes rust-lang#42944 and fixes rust-lang#53430. This commit modifies name resolution error reporting so that if a name is in scope and has been imported then we do not suggest importing it. This can occur when we add a label about constructors not being visible due to private fields. In these cases, we know that the struct/variant has been imported and we should silence any suggestions to import the struct/variant. r? @estebank
Centril
added a commit
to Centril/rust
that referenced
this issue
Feb 13, 2019
Only suggest imports if not imported. Fixes rust-lang#42944 and fixes rust-lang#53430. This commit modifies name resolution error reporting so that if a name is in scope and has been imported then we do not suggest importing it. This can occur when we add a label about constructors not being visible due to private fields. In these cases, we know that the struct/variant has been imported and we should silence any suggestions to import the struct/variant. r? @estebank
Centril
added a commit
to Centril/rust
that referenced
this issue
Feb 13, 2019
Only suggest imports if not imported. Fixes rust-lang#42944 and fixes rust-lang#53430. This commit modifies name resolution error reporting so that if a name is in scope and has been imported then we do not suggest importing it. This can occur when we add a label about constructors not being visible due to private fields. In these cases, we know that the struct/variant has been imported and we should silence any suggestions to import the struct/variant. r? @estebank
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Ran into this trying to connect a diesel db to actix_web. Moodgoodboy on rust-beginners helped in making this MCVE
https://play.rust-lang.org/?gist=0caefd3323a4e74a91c7064e05acd7e9&version=stable&mode=debug
error[E0423]: expected function, found struct 'Executor'The text was updated successfully, but these errors were encountered: