Skip to content

rename vec::from_slice and/or str::to_unique #3356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jesse99 opened this issue Sep 2, 2012 · 4 comments
Closed

rename vec::from_slice and/or str::to_unique #3356

jesse99 opened this issue Sep 2, 2012 · 4 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@jesse99
Copy link
Contributor

jesse99 commented Sep 2, 2012

These do exactly the same thing so it would be nice if they had similar names (I guess this would require making the vector version a method).
@catamorphism
Copy link
Contributor

to_unique is to_owned now, but from_slice is still the same.

@brson
Copy link
Contributor

brson commented Mar 31, 2013

Not 0.6

@sonwow sonwow mentioned this issue May 10, 2013
Merged
bors added a commit that referenced this issue May 11, 2013
@bors
auto merge of #6389 : sonwow/rust/issue-3356, r=bstrie
9572518 
Fix for #3356
@nickdesaulniers
Copy link

What's the status of this bug?

@huonw
Copy link
Member

huonw commented Aug 30, 2013

Fixed by #6389: from_slice was renamed to to_owned.

@huonw huonw closed this as completed Aug 30, 2013
RalfJung pushed a commit to RalfJung/rust that referenced this issue Mar 9, 2024
@bors
Auto merge of rust-lang#3356 - RalfJung:typo, r=RalfJung
4fdb215 
Conjob → Cronjob

Same as rust-lang/miri-test-libstd#44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@brson @jesse99 @catamorphism @huonw @nickdesaulniers