Skip to content

Inlined and monomorphised functions should have llvm internal visibility #2020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brson opened this issue Mar 17, 2012 · 1 comment
Closed

Inlined and monomorphised functions should have llvm internal visibility #2020

brson opened this issue Mar 17, 2012 · 1 comment
Labels
A-codegen Area: Code generation C-cleanup Category: PRs that clean code up or issues documenting cleanup.

Comments

@brson
Copy link
Contributor

brson commented Mar 17, 2012

I see a bunch of my cross crate inlined functions have been optimized out of the call site, but the functions are still defined in the ll asm. Presumably that wouldn't happen if they were internal.
@ghost ghost assigned marijnh Mar 20, 2012
marijnh added a commit that referenced this issue Mar 20, 2012
@marijnh
Move external-reachability checker to trans
ade1207 
Preparation for a fix for issue #2020
@marijnh
Copy link
Contributor

marijnh commented Mar 20, 2012

Done in 928364b (though I mistyped the bug number in the commit message)

@marijnh marijnh closed this as completed Mar 20, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-codegen Area: Code generation C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marijnh @brson